Fix/pdf conversion and institution mappings#3
Merged
HanssonMagnus merged 4 commits intomainfrom Nov 9, 2025
Merged
Conversation
- Fix PDF conversion to handle None/string/bytes returns from textract - Improve error handling (remove unnecessary exception re-raising) - Add Central Bank of Eswatini to institutions list - Add institution aliases: Banco de Portugal, Saudi Central Bank - Update test to reflect improved error handling
- Add Known Limitations section to README - Document PDF encoding issues in API docs - Explain that ~8% of PDFs may fail conversion due to source PDF encoding issues - Clarify this is a PDF quality issue, not a code bug
- Add recategorize_unknown_files() function to re-categorize files from unknown folder - Automatically called after scraping completes - Moves both PDFs and corresponding text files together - Uses updated institution mappings to move files to correct folders - Cleans up empty unknown folders for both PDFs and texts - Makes package more robust when institution mappings are updated - Add comprehensive test coverage (8 tests) for all scenarios - Handle edge cases: missing PDFs, missing text files, partial re-categorization
… adjust the start date for scraping from 2025-10-01 to 2025-08-01.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.